Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: bump versions on releases #99

Merged
merged 9 commits into from
Apr 18, 2024

Conversation

mondeja
Copy link
Member

@mondeja mondeja commented Apr 17, 2024

Currently, the version field of package.json is still stuck at 1.0.5 but the latest released version is v2.7.1. This is because the plugin @semantic-release/git hasn't been configured to push package*.json changed to the GIT repository on releases.

See https://github.com/semantic-release/git

  • Used semantic-release/[email protected] because is the latest compatible with Node.js v12.20.0.
  • Used Node.js v20.11.0 to update the package-lock.json.

@mondeja mondeja requested a review from LitoMore April 17, 2024 20:22
@mondeja mondeja marked this pull request as draft April 17, 2024 20:30
@mondeja mondeja removed the request for review from LitoMore April 17, 2024 20:30
@mondeja mondeja requested a review from LitoMore April 17, 2024 20:52
@mondeja mondeja marked this pull request as ready for review April 17, 2024 20:53
@LitoMore
Copy link
Member

Let's change the token to our bot token:

- name: Release
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
NPM_TOKEN: ${{ secrets.NPM_TOKEN }}
run: npx semantic-release

@mondeja
Copy link
Member Author

mondeja commented Apr 18, 2024

I prefer to do that in another PR to not mix contexts.

@LitoMore LitoMore merged commit b5ed659 into simple-icons:master Apr 18, 2024
14 checks passed
@mondeja mondeja deleted the bump-version-on-releases branch April 18, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants