Added start date in TextTransformer #161
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm hesitant on this one because it makes many of the strings read awkwardly and maybe a bit too verbose. e.g. In my personal usages of Recurr, I like that it just describes the recurrence rule and doesn't include the start date. I think that if one wants to include the start date, it would be better to manually prepend something like "Starting on %date%, ". I'm open to other opinions though. Test suite: |
|
What do you think about adding a parameter to the "transform" function, containing an array of elements to exclude? public function transform(Rule $rule, $exclude = array())if (!in_array('startDate', $exclude)) {
$startDate = $rule->getStartDate();
if ($startDate instanceof \DateTimeInterface) {
$dateFormatted = $this->translator->trans('day_date', array('date' => $startDate->format('U')));
$this->addFragment($this->translator->trans('from %date%', array('date' => $dateFormatted)));
}
}And why not the same thing for "until"? |
|
I love the idea of being able to make the text output more granular. For example, I like the idea of showing the day of the month on monthly events, and would like to see the time included for weekly events. Personally I wouldn't want to see the start date included, but overall I think it would be great if this could be configurable in some way to allow it to meet the needs of a particular site. |
williamdes
reviewed
Dec 24, 2021
| @@ -14,7 +14,7 @@ public function __construct(TranslatorInterface $translator = null) | |||
| $this->translator = $translator ?: new Translator('en'); | |||
| } | |||
|
|
|||
| public function transform(Rule $rule) | |||
| public function transform(Rule $rule, $exclude = array()) | |||
There was a problem hiding this comment.
Suggested change
| public function transform(Rule $rule, $exclude = array()) | |
| public function transform(Rule $rule, $exclude = []) |
https://github.com/simshaun/recurr/blob/master/composer.json#L16
Old PHP 5.3 compat is not needed :) (https://github.com/wdes/coding-standard#rules-to-disable-for-php--54-compatibility)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
For more verbosity on the Rule, I added the start date to the translations for TextTransformer.
Please check the translations (except french haha).
If everything is ok, I will add the associated tests.