Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isoWeekDay to Weekday object #203

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gazben
Copy link

@gazben gazben commented Nov 24, 2022

Currently the $weekday variable will contain the result of the array_search($weekday, $this->days);. The $days array starts with "MO" and not "SU" as stated in the comment above.

To use this library with Carbon I suggest to add the ISO weekday to the Weekday object.

The ISO weekday definition: https://en.wikipedia.org/wiki/ISO_week_date

Weekday number, a digit d from 1 through 7, beginning with Monday and ending with Sunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant