Skip to content

Commit

Permalink
[Gear] Legendary Skippers Estimate tidyup
Browse files Browse the repository at this point in the history
* Tidy up code for estimating skippers and choosing the default variant
  to use
  • Loading branch information
Saeldur committed Dec 17, 2024
1 parent 9cbf3a6 commit 188d117
Showing 1 changed file with 2 additions and 7 deletions.
9 changes: 2 additions & 7 deletions engine/player/unique_gear_thewarwithin.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -6494,22 +6494,17 @@ struct roaring_warqueen_citrine_t : public spell_t

void execute() override
{
bool old_group_value = estimate_group_value;
bool skippers_estimate = player->thewarwithin_opts.estimate_skippers_group_benefit &&
( player->sim->single_actor_batch || player->sim->player_no_pet_list.size() == 1 );
// Base of 1 + small epsilon to avoid rounding errors.
if ( base_multiplier > 1.001 &&
( player->thewarwithin_opts.force_estimate_skippers_group_benefit || skippers_estimate ) )
{
bool old_group_value = estimate_group_value;
// Can only happen with Legendary Skippers
estimate_group_value = player->thewarwithin_opts.estimate_skippers_group_benefit &&
player->thewarwithin_opts.force_estimate_skippers_group_benefit;
estimate_group_value = true;
if ( estimate_group_value != old_group_value )
target_cache.is_valid = false;

// Currently there is an Issue with fake Actors initialising the ring. TODO: look into it.
if ( !sim->single_actor_batch )
return;
}

if ( target_list().size() == 0 )
Expand Down

0 comments on commit 188d117

Please sign in to comment.