Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 8.2 flask and feast to monk/shaman/hunter/death knight #4852

Closed

Conversation

MayContainNutz
Copy link

battle potions remain untouched

@@ -9366,7 +9366,7 @@ std::string monk_t::default_flask() const
break;
case MONK_MISTWEAVER:
if ( true_level > 110 )
return "endless_fathoms";
return "greater_flask_of_endless_fathoms";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ This conflicts with PR #4942 commit 8e29110

However it is possibly a more appropriate fix. Either way the merge conflict resolution should be trivial.

@kendrick-walls-work
Copy link
Contributor

I'm working on a conflict resolution merge

kendrick-walls-work added a commit to kendrick-walls-work/simc that referenced this pull request Sep 11, 2019
@kendrick-walls-work
Copy link
Contributor

❌ these changes have been assimilated into PR #4948
RECOMMEND CLOSING THIS OBSOLETE PULL REQUEST
rational: keep this PR for the comment history if ever needed but close as resolved to avoid detached state in the future

@kendrick-walls-work
Copy link
Contributor

❌ these changes have been cherry picked into PRs #4949 #4950
RECOMMEND CLOSING THIS OBSOLETE PULL REQUEST
rational: keep this PR for the comment history if ever needed but close as resolved to avoid detached state (merge conflicts) and confusion and cross team dependancies in the future

@Melekus
Copy link
Contributor

Melekus commented Sep 11, 2019

Most of the proposed changes have been applied individually in other commits, closing the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants