[Core] Fix precombat order of operations #9781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the order of event issues present due to the Singing Citrine effects. In order to accomplish this, i've removed the APL action accessibility for Flask, Food and Augmentation actions and instead trigger them early in `player_t::arise()`. This is a requirement due to the APL actions being called after precombat_callbacks that are often utilized to apply effects that will utilize the players current state on combat entry, which will include flask, food, and augment rune effects. May also change the results with effects like Ovinax's Mercurial Egg, if the stat provided by flask or food changes the highest secondary stat, as before this wouldn't be updated until the first tick.
…error if this happens.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the order of event issues present due to the Singing Citrine effects. In order to accomplish this, i've removed the APL action accessibility for Flask, Food and Augmentation actions and instead trigger them early in
player_t::arise(). This is a requirement due to the APL actions being called after precombat_callbacks that are often utilized to apply effects that will utilize the players current state on combat entry, which will include flask, food, and augment rune effects.May also change the results with effects like Ovinax's Mercurial Egg, if the stat provided by flask or food changes the highest secondary stat, as before this wouldn't be updated until the first tick.