Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fast-glob to benchmarks #51

Merged
merged 1 commit into from
Oct 30, 2017
Merged

Add fast-glob to benchmarks #51

merged 1 commit into from
Oct 30, 2017

Conversation

kevva
Copy link
Contributor

@kevva kevva commented Oct 30, 2017 •
edited
Loading

In a step towards fixing #50, this might be useful to have. Currently it looks like fast-glob is faster than globby.

@sindresorhus
Copy link
Owner

Speed is cool, but correctness is also important. node-glob is used in production considerably more than fast-glob. Let's reconsider it when mrmlnc/fast-glob#15 is done.

@sindresorhus sindresorhus merged commit 909cfa1 into master Oct 30, 2017
@sindresorhus sindresorhus deleted the fast-glob-bench branch October 30, 2017 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevva @sindresorhus