Check parcel status before calling unmount #95
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been running into the following error using the Parcel component:
This occurs when the parent application unmounts. Looking at the lib, there's no check on the parcel status before calling
unmount
.My change is the equivalent of this line in single-spa-react:
https://github.com/single-spa/single-spa-react/blob/main/src/parcel.js#L66
Ensuring that
unmount
is only ever called on parcels with a status ofMOUNTED
.I would be grateful if someone more familiar with the project could please review this, hoping it's suitable to merge!