added actorSit actorGetUp actorRaycast calculateAnticipatedLocation #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pospelove
requested changes
Jun 3, 2024
There was a problem hiding this comment.
Overall seems good, thank you!
Could you please a 1-line changelog entry like sp-***.md
in this folder:
https://github.com/skyrim-multiplayer/skymp/tree/main/docs/release/dev
Also please in this file add the following lines it the end. Then compile and commit result (compile will run TS codegen). This will make you fuction callable from TypeScript.
export declare function actorSit(formId: number): void;
export declare function actorGetUp(actorId: number): void;
export declare function actorRaycast(actorId: number, r: number): number[];
export declare function calculateAnticipatedLocation(actorId: number): number[];| a->actorState1.sitSleepState = RE::SIT_SLEEP_STATE::kIsSitting; | ||
| } | ||
|
|
||
| void getUp(RE::Actor* a) |
There was a problem hiding this comment.
Let's meet skymp naming guidelines
getUp -> GetUp
sit -> Sit
etc
| { | ||
| auto havokWorldScale = RE::bhkWorld::GetWorldScale(); | ||
| RE::bhkPickData pick_data; | ||
| RE::NiPoint3 ray_start, ray_end; |
There was a problem hiding this comment.
ray_start -> rayStart, etc
| return point2js(ans); | ||
| } | ||
|
|
||
| void Register(JsValue& exports) |
There was a problem hiding this comment.
We need to call this function here
Pospelove
reviewed
Jun 3, 2024
Pospelove
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.