Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsync zone #2219

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Unsync zone #2219

wants to merge 3 commits into from

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Nov 16, 2024

Important

Add SweetTaffySuspendSyncInTutorialService to manage sync suspension in tutorial zones and integrate with event system.

  • Behavior:
    • Introduces SweetTaffySuspendSyncInTutorialService to suspend sync in tutorial zones in index.ts and sweetTaffySuspendSyncInTutorialService.ts.
    • Adds querySuspendSync event in events.ts and querySuspendSync.ts to handle sync suspension requests.
    • Modifies FormViewArray to check and handle sync suspension during form updates.
  • Error Handling:
    • Fixes typo in error message in spApiInteractor.ts.
  • Misc:
    • Adds comments in sweetTaffyPlayerCombatService.ts for future improvements and references to the new service.

This description was created by Ellipsis for 1880505. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 1880505 in 51 seconds

More details
  • Looked at 266 lines of code in 7 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_VA5piy1Xg2vQe24m


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

skymp5-client/src/services/spApiInteractor.ts Outdated Show resolved Hide resolved
Pospelove and others added 2 commits November 16, 2024 23:53
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@Pospelove
Copy link
Contributor Author

TODO: fix index.ts conflict in gather

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant