Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(skymp5-client): process hits from non-weapon sources #2231

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

Pospelove
Copy link
Contributor

@Pospelove Pospelove commented Nov 26, 2024

Important

onHit() in hitService.ts now processes hits from spells and scrolls, not just weapons.

  • Behavior:
    • In hitService.ts, onHit() now processes hits from sp.Spell and sp.Scroll sources, in addition to sp.Weapon.
  • Misc:
    • Addresses TODO to allow non-weapon sources in onHit() function.

This description was created by Ellipsis for e6a7bfe. It will automatically update as commits are pushed.

@ellipsis-dev ellipsis-dev bot changed the title . feat(hitService): process hits from spells and scrolls Nov 26, 2024
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to e6a7bfe in 10 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. skymp5-client/src/services/services/hitService.ts:42
  • Draft comment:
    The addition of this.sp.Spell.from(e.source) and this.sp.Scroll.from(e.source) addresses the TODO on line 17 to allow non-weapon sources. Ensure that this.sp.Spell.from and this.sp.Scroll.from are correctly implemented and handle all necessary cases.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR adds support for spells and scrolls as hit sources, which aligns with the TODO comment on line 17.

Workflow ID: wflow_PAXcEbPWSYlp7Iub


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@Pospelove Pospelove changed the title feat(hitService): process hits from spells and scrolls feat(skymp5-client): process hits from non-weapon sources Nov 26, 2024
@Pospelove Pospelove merged commit f74b9d8 into skyrim-multiplayer:main Nov 26, 2024
13 checks passed
@Pospelove Pospelove deleted the kkk branch November 26, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant