Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added method tooling.tokens.rotate #1204

Closed
wants to merge 1 commit into from

Conversation

dhalturin
Copy link

Added sending a request for the method:
https://api.slack.com/methods/tooling.tokens.rotate

Exchanging a refresh token for a new app configuration token.

@dhalturin
Copy link
Author

@kanata2, hello! could you please check this PR?

Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't appear to be harmful/breaking.

@parsley42 parsley42 closed this Feb 10, 2024
@parsley42 parsley42 reopened this Feb 10, 2024
@parsley42
Copy link
Member

Ah, I see this introduced a conflict with another merged PR - automated testing FTW I guess. Feel free to rework this to gel with the current tree.

@dhalturin
Copy link
Author

@parsley42, branch has been synced with master

@dhalturin
Copy link
Author

lol, the method was added while the PR was open for half a year

@parsley42
Copy link
Member

@dhalturin Hah - yeah, I'm really just filling in as maintainer until somebody better steps up. I figure the work I'm doing is better than no merges at all. In any case, it looks like the tests are still failing?:

panic: http: multiple registrations for /tooling.tokens.rotate [recovered]
	panic: http: multiple registrations for /tooling.tokens.rotate

@dhalturin
Copy link
Author

@parsley42, I think it doesn't matter now _)

@dhalturin dhalturin closed this Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants