Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve updater and Go -> 1.20 #172

Merged
merged 5 commits into from
Aug 27, 2024
Merged

Improve updater and Go -> 1.20 #172

merged 5 commits into from
Aug 27, 2024

Conversation

asalvi0
Copy link
Contributor

@asalvi0 asalvi0 commented Aug 25, 2024

Cleaned up the UpdateAll method to reuse Update, should be easier to maintain.

Notes:
The additional indirect dependencies in go.sum come from github.com/stretchr/testify after running go mod tidy

@smacker
Copy link
Owner

smacker commented Aug 26, 2024

hi @asalvi0 ! Thank you! But let's support at least 3 latest versions of go. No everybody migrates immediately :)

@asalvi0 asalvi0 changed the title Improve updater and Go -> 1.23 Improve updater and Go -> 1.20 Aug 26, 2024
@asalvi0
Copy link
Contributor Author

asalvi0 commented Aug 26, 2024

hi @asalvi0 ! Thank you! But let's support at least 3 latest versions of go. No everybody migrates immediately :)

@smacker I've downgraded to 1.20; all tests are passing locally.

@smacker
Copy link
Owner

smacker commented Aug 27, 2024

Could you please update this file https://github.com/smacker/go-tree-sitter/blob/master/.github/workflows/test.yml by removing go1.19 and adding go1.23? Looks like I can't push into your branch. Otherwise the CI will fail.

@asalvi0
Copy link
Contributor Author

asalvi0 commented Aug 27, 2024

Could you please update this file https://github.com/smacker/go-tree-sitter/blob/master/.github/workflows/test.yml by removing go1.19 and adding go1.23? Looks like I can't push into your branch. Otherwise the CI will fail.

@smacker done.

@smacker smacker merged commit dd81d9e into smacker:master Aug 27, 2024
4 checks passed
@smacker
Copy link
Owner

smacker commented Aug 27, 2024

thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants