Add Content-Type header to Slack notifier - req. for discord #494
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was working on building
discord
webhook for this repo, then I came across Discord - Slack Compatible Docs.This means we can use
slack
notifier with Discord webhook(plus adding/slack
at the end of discord webhook url). Ex:But the problem is, Discord webhooks requires header
Content-Type: application/json
set to it. This is pretty standard and recommended for all API apps. Seems that, for Slack API this header is optional, so right now the above discord webhook will fail.So, I've just added the
Content-Type
header to the Slack Notifier, this will work for both Slack and Discord.