Merge pull request #39 from snyk/fix/recognotion_bundle_that_contains…

…_no_files fix: recognition of bundle that contains no files
snyk · May 19, 2022 · d52b12c · d52b12c
2 parents c14dbf6 + a1c51f3
commit d52b12c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,6 @@
+## [2.3.3] - 2022-05
+- fix: recognition of bundle that contains no files
+
 ## [2.3.2] - 2022-05
 - fix: make re-try attempts for most api calls if not succeed for any reason (except 401 - auth failed)
 

diff --git a/build.gradle b/build.gradle
@@ -6,7 +6,7 @@ plugins {
 
 group = "io.snyk.code.sdk"
 archivesBaseName = "snyk-code-client"
-version = "2.3.2"
+version = "2.3.3"
 
 repositories {
     mavenLocal()

diff --git a/src/main/java/ai/deepcode/javaclient/core/AnalysisDataBase.java b/src/main/java/ai/deepcode/javaclient/core/AnalysisDataBase.java
@@ -592,11 +592,8 @@ private CreateBundleResponse makeNewBundle(
               new ExtendBundleWithHashRequest(request, removedFiles));
     }
     String newBundleId = bundleResponse.getBundleHash();
-    // By man: "Extending a bundle by removing all the parent bundle's files is not allowed."
-    // In reality new bundle returned with next bundleID:
-    // .../DEEPCODE_PRIVATE_BUNDLE/0000000000000000000000000000000000000000000000000000000000000000
-    if (newBundleId.endsWith(
-        "/DEEPCODE_PRIVATE_BUNDLE/0000000000000000000000000000000000000000000000000000000000000000")) {
+    // assigned to every bundle that contains no files
+    if (newBundleId.endsWith("0000000000000000000000000000000000000000000000000000000000000000")) {
       newBundleId = "";
     }
     checkApiCallSucceed(project, bundleResponse, "Bad Create/Extend Bundle request: ");