fix: disable certificate trust correctly (#55)

snyk · Dec 18, 2024 · 1871613 · 1871613
1 parent 8d3a487
commit 1871613
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/snyk-universal-broker/templates/statefulset.yaml b/snyk-universal-broker/templates/statefulset.yaml
@@ -168,7 +168,7 @@ spec:
               value: /home/node/tls-cert/tls.key
           {{- end }}
           {{- end }}
-        {{- if or (and .Values.tlsRejectUnauthorized (not .Values.caCert)) (and .Values.caCert .Values.disableAllCertificateTrust) }}
+        {{- if .Values.disableAllCertificateTrust }}
          # Troubleshooting - Set to 0 for SSL inspection testing
             - name: NODE_TLS_REJECT_UNAUTHORIZED
               value: "0"

diff --git a/snyk-universal-broker/tests/certificate_trust_test.yaml b/snyk-universal-broker/tests/certificate_trust_test.yaml
@@ -101,3 +101,14 @@ tests:
             mountPath: /home/node/cacert
             readOnly: true
         template: statefulset.yaml
+
+  - it: disables all CA trust
+    set:
+      disableAllCertificateTrust: true
+    asserts:
+    - contains:
+        path: spec.template.spec.containers[0].env
+        content:
+          name: NODE_TLS_REJECT_UNAUTHORIZED
+          value: "0"
+      template: statefulset.yaml