fix: sign helm chart [HYB-731] #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soniqua
force-pushed
the
fix/sign-helm-chart
branch
from
b9a4352 to
7d82276
Compare
soniqua
force-pushed
the
fix/sign-helm-chart
branch
from
7d82276 to
c62f85e
Compare
saumilmac
approved these changes
Nov 18, 2024
soniqua
added a commit
that referenced
this pull request
Nov 28, 2024
* feat: uni broker helm chart * chore: [skip ci] remove tag * fix: ci and release config (#17) * fix: ci and release config * chore: editorconfig * fix: disable helm chart publishing * chore: remove test cases doc * fix: update ca cert trust settings (#18) * fix: update ca cert trust settings * fix: docs to readme, correct var to disable cert trust * fix: correct dockerhub password * fix: support ACCEPTS_ (#19) * fix: support ACCEPTS_ * fix: dockerhub password * chore: expand dockerhub password (#20) * fix: correct serviceAccount format (#25) * fix: add missing serviceName field (#26) * ci: move kubeconform to validate step (#27) * fix: correct tenant to region (#23) * fix: custom docker registry (#35) * fix: specify universal broker platform auth and credential references (#24) * fix: implement ingress and service (#29) * fix: implement ingress and service * fix: high availability mode, limits and requests, tolerations, affinities (#30) * fix: high availability mode, limits and requests * fix: tolerations, selectors, affinities * fix: security context, openshift adaptation (#28) * fix: enable commit signing (#21) * fix: broker serve tls (#22) * fix: support outbound proxy config (#31) * fix: extra k8s objects, sidecars, initContainers (#32) * fix: add logging levels, probe definitions (#33) * fix: insecure downstream mode (#34) * fix: preflight checks (#36) * fix: preflight checks * fix: remove preflight checks disable value * fix: strict schema checking, cleanup (#40) * ci: enable deploy and test (#37) * ci: adds a queue step to prevent concurrent deploy/test cycles * ci: upsize executor * ci: helmignore * ci: remove useless log * fix: add runtimeclass and priorityclass (#39) * ci: enable helm push (#43) * chore: apply prettier formatting (#41) * chore: fix precommit config for prettier * chore: prettier * ci: add security gates (#42) * ci: add gates to PR workflow * ci: add template for IaC scan * fix: sign helm chart (#45) * docs: LICENSE (#46) * fix: publish and sign jobs (#47) * fix: add missing gh context * fix: change trigger from check_suite to release * ci: use team-hybrid-common for github token (#48) * fix: strip v from tag (#49) * fix: remove registry-1.docker.io prefix (#50) * fix: ensure post install notes reflect the Snyk region (#52) --------- Co-authored-by: saumil Macwan <[email protected]>
soniqua
added a commit
that referenced
this pull request
Nov 28, 2024
* feat: uni broker helm chart * fix: ci and release config (#17) * fix: ci and release config * chore: editorconfig * fix: disable helm chart publishing * chore: remove test cases doc * fix: update ca cert trust settings (#18) * fix: update ca cert trust settings * fix: docs to readme, correct var to disable cert trust * fix: correct dockerhub password * fix: support ACCEPTS_ (#19) * fix: support ACCEPTS_ * fix: dockerhub password * chore: expand dockerhub password (#20) * fix: correct serviceAccount format (#25) * fix: add missing serviceName field (#26) * ci: move kubeconform to validate step (#27) * fix: correct tenant to region (#23) * fix: custom docker registry (#35) * fix: specify universal broker platform auth and credential references (#24) * fix: implement ingress and service (#29) * fix: implement ingress and service * fix: high availability mode, limits and requests, tolerations, affinities (#30) * fix: high availability mode, limits and requests * fix: tolerations, selectors, affinities * fix: security context, openshift adaptation (#28) * fix: enable commit signing (#21) * fix: broker serve tls (#22) * fix: support outbound proxy config (#31) * fix: extra k8s objects, sidecars, initContainers (#32) * fix: add logging levels, probe definitions (#33) * fix: insecure downstream mode (#34) * fix: preflight checks (#36) * fix: preflight checks * fix: remove preflight checks disable value * fix: strict schema checking, cleanup (#40) * ci: enable deploy and test (#37) * ci: adds a queue step to prevent concurrent deploy/test cycles * ci: upsize executor * ci: helmignore * ci: remove useless log * fix: add runtimeclass and priorityclass (#39) * ci: enable helm push (#43) * chore: apply prettier formatting (#41) * chore: fix precommit config for prettier * chore: prettier * ci: add security gates (#42) * ci: add gates to PR workflow * ci: add template for IaC scan * fix: sign helm chart (#45) * docs: LICENSE (#46) * fix: publish and sign jobs (#47) * fix: add missing gh context * fix: change trigger from check_suite to release * ci: use team-hybrid-common for github token (#48) * fix: strip v from tag (#49) * fix: remove registry-1.docker.io prefix (#50) * fix: ensure post install notes reflect the Snyk region (#52) --------- Co-authored-by: saumil Macwan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
cosign, leveraging keyless signature via OIDCWhy
More
Keyless signatures are beneficial as:
How
The GitHub Actions OIDC token is supported by
cosignas an OIDC provider - no additional configuration is required aside from specifying theid-token: writepermission. This is why we need to sign OCI artefacts in a GitHub Actions workflow.The CircleCI OIDC token does not support the required fields to be leveraged by
cosignas a native OIDC provider (sigstore/fulcio#591).Refs