Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adds centralized author map to streamline resource entries #552

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thedanchez
Copy link
Contributor

@thedanchez thedanchez commented Oct 14, 2024

Refactors the Resource entries under Utilities.data.ts to use new helper methods: packageBy and libraryBy.

Those two helper methods are meant to reduce the amount of repetitive entries for the author, author_url and type per each Resource record put into the list.

I think I like this since it co-locates all the unique library authors into a single map struct so one can appreciate all the work done by said individuals for the Solid community instead of all of them being "lost in the sea of records"

@thedanchez
Copy link
Contributor Author

@davedbase whenever you have time, curious to get your thoughts on this approach here to consolidate things a bit and reduce the amount of repeated field entries for the records in this file.

@thedanchez thedanchez force-pushed the author-refactor branch 4 times, most recently from 339321c to b7e5151 Compare October 14, 2024 20:15
@davedbase
Copy link
Member

Thanks so much for looking into this. The honest truth is that I was hoping to completely refactor this out of a JSON file. As the ecosystem is growing the file for storing this is growing, it makes more sense to put this in a different storage solution. For a while I was considering an API so that we can handle dynamic submissions and such.

@thedanchez thedanchez force-pushed the author-refactor branch 3 times, most recently from 3a74baf to a6bf7b8 Compare October 16, 2024 18:56
@thedanchez thedanchez force-pushed the author-refactor branch 6 times, most recently from 7982d26 to 23f1ccb Compare December 1, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants