-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EdDSA/Minisign signatures to #397 (sign-hash/sign-file CTAP command) #583
Open
stevenwdv
wants to merge
8
commits into
solokeys:master
Choose a base branch
from
stevenwdv:sign-hash
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Commits on Oct 18, 2021
-
PoC: Add vendor command for signing an arbitrary SHA256 hash
This patch adds new CTAP2 vendor command with command value 0x50. The command arguments are credentialId and user specified SHA256 hash. It returns a DER encoded signature of the given hash, using the key which corresponds to the specified credentialId. Example request: {1: <sha256_hash>, 2: {"id": <credential_id>, "type": "public-key"}, 3: [pinAuth]} Example response: {1: <der_signature>} Issue: solokeys#395
Configuration menu - View commit details
-
Copy full SHA for ebef6da - Browse repository at this point
Copy the full SHA ebef6daView commit details
Commits on Oct 20, 2021
-
Added EdDSA/Minisign to sign-hash/sign-file command (first version) w…
…ith support for arbitrary-length hashes up to 64B and a trusted comment in the EdDSA case. Also fixed existing bug: get_credential_id_size(SH.cred.type) should be get_credential_id_size(&SH.cred) Also now cose_alg is checked. I'm not sure yet if it is safe to use arbitrary-length hashes with verify_pin_auth_ex. Maybe a min length should be set?
Configuration menu - View commit details
-
Copy full SHA for 51c0b87 - Browse repository at this point
Copy the full SHA 51c0b87View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7708b97 - Browse repository at this point
Copy the full SHA 7708b97View commit details
Commits on Oct 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 1fd5b74 - Browse repository at this point
Copy the full SHA 1fd5b74View commit details -
sign-hash: validate hash length per signature algorithm, check if sig…
…nature algorithm is supported
Configuration menu - View commit details
-
Copy full SHA for 861d783 - Browse repository at this point
Copy the full SHA 861d783View commit details -
Configuration menu - View commit details
-
Copy full SHA for d067d94 - Browse repository at this point
Copy the full SHA d067d94View commit details
Commits on Oct 27, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c26a983 - Browse repository at this point
Copy the full SHA c26a983View commit details
Commits on Oct 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for fd8033b - Browse repository at this point
Copy the full SHA fd8033bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.