Added WDC ssd health #300
Open
Added WDC ssd health #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 1 alert when merging 844e65e into 030a382 - view on LGTM.com new alerts:
|
deran1980
force-pushed
the
xsight-platform-dev
branch
from
844e65e
to
e19f696
Compare
|
@prgeor can you please assist in reviewing this PR? |
|
Hi @stephenxs - can you help with review of this PR? |
prgeor
previously approved these changes
Dec 1, 2023
|
@assrinivasan could you review |
|
@deran1980 could you add code coverage? |
bluecmd
reviewed
May 1, 2024
…form-common into xsight-platform-dev
| self.firmware = self._parse_re('Firmware Version:\s*(.+?)\n', self.ssd_info) | ||
| try: | ||
| if ("SDASN8Y1T00" == self.model.split(' ')[3]): | ||
| self.nand_endurance = 400 * 1000 |
There was a problem hiding this comment.
Hi @deran1980 - could you please elaborate on why NAND endurance is set to this value?
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
Signed-off-by: maipbui <[email protected]> Signed-off-by: maipbui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Eran Dahan [[email protected]]
What I did
Added support for a new SSD appliance from WDC
How I did it
Modify ssd_genric.py to extend support of a new SSD
Verify on Accton platform (based on Xsight ASIC) with WDC SSD
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)