Added a procfs check for pcie peripherals to verify device ID. #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
assrinivasan
requested review from
Staphylo,
dgsudharsan,
keboliu,
prgeor and
Junchao-Mellanox
assrinivasan
removed request for
Staphylo,
dgsudharsan,
keboliu,
prgeor and
Junchao-Mellanox
assrinivasan
requested review from
Staphylo,
dgsudharsan,
keboliu,
prgeor and
Junchao-Mellanox
prgeor
reviewed
May 1, 2024
| try: | ||
| with open(current_file, 'rb') as f: | ||
| f.seek(2) | ||
| data = f.read(2) |
There was a problem hiding this comment.
@assrinivasan does this result in real pcie transaction?
There was a problem hiding this comment.
This does not -- this gets the intended device ID of the PCIe device by querying the procfs data file directly, thereby bypassing any SCD driver hijack or pcie*.yaml file weirdness. I added the actual transaction check in the latest commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a procfs check for PCI peripherals. It provides a device ID check to ensure that the PCI peripherals match the pcie.yaml manifest, including undercutting PCI device hijack by other drivers that might change the device ID.
Motivation and Context
The motivation for this PR is to get ahead the 'ASIC missing' issue and provide a mechanism to auto-mitigate said issues.
Fixes #191
How Has This Been Tested?
Ran following tests:
on the following HardwareSKUs:
procfs_pcie_check_deviceid_mismatch_logs.txt
Additional Information (Optional)