-
-
Notifications
You must be signed in to change notification settings - Fork 923
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Boot - set env vars for pipewire (matching pw-jack's behaviour) (#3349)
pw-jack sets the PIPEWIRE_QUANTUM and LD_LIBRARY_PATH env vars before execing a binary. To use this we'd need to run sonic pi from pw-jack (so the exec would do its work correctly). Instead of that we set the env vars within the call to popen2e when starting scsynth to match this behaviour. It is now also possible to use new change pipewire's buffsize and samplerate with two new audio-settings.toml config options: ``` linux_pipewire_buffsize = 1024 linux_pipewire_samplerate = 4800 ```
- Loading branch information
Showing
2 changed files
with
55 additions
and
5 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5fbe330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@porras if you have a spare moment, could you test to see if this commit (and the current state of the dev branch) is compatible with your Flatpak build process? I think we're pretty much ready for tagging...
5fbe330
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! I did (sorry I commented in the pr #3349). It works and as far as flatpak is concerned it is good to go. I mentioned a possible backwards compatibility issue but it's theoretical, I cannot test that on my system which does have pipewire.