Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update user properties #1062

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update user properties #1062

wants to merge 1 commit into from

Conversation

Puyodead1
Copy link
Contributor

This PR adds some missing properties to the User entity, and updates the user profile endpoint to match Discord.

erkinalp
erkinalp approved these changes May 19, 2023
View reviewed changes
Copy link
Contributor

@erkinalp erkinalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks fine

@Puyodead1 Puyodead1 marked this pull request as ready for review May 19, 2023 20:59
@Puyodead1
Copy link
Contributor Author

I think this needs migrations though, but idk how the fk do make them anymore.

@MaddyUnderStars
Copy link
Member

There's a whole mf docs page about how to generate migrations https://docs.spacebar.chat/contributing/server/migrations
But really this just does npm run sync:db so you'll want to rewrite it yourself

@Puyodead1 Puyodead1 added the Needs rebase Attempt to merge into master label Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erkinalp erkinalp erkinalp approved these changes

@TheArcaneBrony TheArcaneBrony Awaiting requested review from TheArcaneBrony

@MaddyUnderStars MaddyUnderStars Awaiting requested review from MaddyUnderStars

Assignees
No one assigned
Labels
Needs rebase Attempt to merge into master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Puyodead1 @MaddyUnderStars @erkinalp