Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some new tests (HETC-885) #158

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Adding some new tests (HETC-885) #158

merged 4 commits into from
Jul 23, 2024

Conversation

isaacspitzer
Copy link
Collaborator

@isaacspitzer isaacspitzer commented Jul 22, 2024

Added a couple new tests and am using this PR to test CI. Tests were automatically kicked off when the PR was opened, and were also kicked off as I pushed new changes after the PR was already open. Test results can be found in the "Checks" tab at the top, next to the "Files changed" tab.

@isaacspitzer
Copy link
Collaborator Author

I determined what tests to add by using the codecov tool, which plugs into github.
https://app.codecov.io/
You should be able to set up an account with your github credentials, then look at the pysynphot project. It shows how much of the project is covered by your test cases, and you can look through the files and see exactly which lines are hit by test cases, and which lines/methods have no coverage.

Copy link
Collaborator

@cdsontag cdsontag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all rather exciting

Copy link
Collaborator

@oiintam oiintam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI feature looks very interesting and I am excited!

Copy link
Collaborator

@ariedel ariedel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very interested to see what else we can do with Github CI

@isaacspitzer isaacspitzer merged commit a23d65f into master Jul 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants