chore(cleanup): refactoring down to single accounts across all services #935
Conversation
| return getBackendUpdater().getBackendDatabase().getLocations(); | ||
| } | ||
|
|
||
| @JsonIgnore private transient BackendUpdater backendUpdater; |
There was a problem hiding this comment.
I know it might be a little early to ask, but if you intend on making these credentials storable, then it would also make sense for them to work similarly through the API. Simply supporting JPA isn't enough; we'd need a way to marshal and unmarshal these through the REST API so that they can be specified from somewhere other than a config file in the first place.
| private String apiKey; | ||
| private String applicationKey; | ||
|
|
||
| @NotNull private RemoteService endpoint; | ||
| @JsonIgnore private transient InfluxDbRemoteService influxDbRemoteService; |
There was a problem hiding this comment.
Might make more sense to use @JacksonInject here instead?
|
Looks interesting, but this diverges so much from anything remotely similar to the Kork credentials API that I'm still unsure how this will eventually integrate with secrets, storage, and the REST API. I see a note about some code being potentially useful as a |
|
SO the goal with this was : Get down to the minimum to work. Remove the cruft. THEN start rebuilding it to match an appropriate API whatever that might look like without breaking/changing any functionality. E.g. This is a pure "cleanup". Next add features LIKE matching/implementing a common API. There's a potential that depending on how we did things, we might find that we get what we need without a lot of extra work. That said I expect long term to have to bring back at least some of the concepts I'm removing though hopefully in a cleaner way! But it's a lot easier to add afterwards from a clean start than try to clean up as part of a migration. |
|
I see. We've diverged quite a bit then at this point, so my previous RFC to add RBAC to Kayenta won't be possible until we've figured that out. |
|
Any chance this can wait til after 1.30? 🤞 that happens "real soon now" ™️ |
|
Not a rush on my side... see if others pushing for it, and there are other PRs coming I'd think as well on the above. I always considered this a starting refactor. |
Significant refactor of accounts to reduce duplication. Prepares for SQL account repository handling.