Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Errors handling and objects fetching from s3. #959

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Errors handling and objects fetching from s3. #959

wants to merge 1 commit into from

Conversation

armory-abedonik
Copy link
Contributor

@armory-abedonik armory-abedonik commented Apr 24, 2023 •
edited
Loading

Fixed bugs:

  • The first bug is related to the fact that the AWS API started returning folder paths along with objects.
  • The second bug is that the error messages are not displayed correctly.

@armory-abedonik armory-abedonik marked this pull request as ready for review April 24, 2023 15:09
jasonmcintosh
jasonmcintosh requested changes Apr 24, 2023
View reviewed changes
Copy link
Member

@jasonmcintosh jasonmcintosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need some tests please ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonmcintosh jasonmcintosh jasonmcintosh requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@armory-abedonik @jasonmcintosh