Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimal PhISEM (Shaker) physical model #18

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lfesp
Copy link

@lfesp lfesp commented Mar 29, 2024

This PR adds a minimal implementation of Perry Cook's PhISEM model, a statistically-derived physical model for particle synthesis.

Issue: this implementation is not complete, as there is an issue with the BiQuad filtering. However, switching to a tSVF as the model's resonator works correctly.

p->gain = gain;
}

void tShaker_setResonance (tShaker *const pm, Lfloat freq, Lfloat radius) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that getting rid of the resonator field entirely, and instead returning the direct output p->level * tNoise_tick(&p->noise) on each tick, would make for a better API. This is fine because there's no feedback.

If we let the user handle the filtering/resonance, they can set up and modify as many resonating stages as they like (which is used on almost all of Cook's PhISEM presets), and we don't have to expose a wrapper to tBiQuad_setResonance for tShaker.

@spiricom
Copy link
Owner

spiricom commented Mar 29, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants