Rescue from failure when neither ip nor ifconfig exists #39
Conversation
| UUIDTools::UUID.ip_command = "nonexistent" | ||
| UUIDTools::UUID.ip_path_default = "/bin/nonexistent" | ||
|
|
||
| expect(UUIDTools::UUID.ifconfig).to eq('') |
There was a problem hiding this comment.
Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
`UUIDTools::UUID.ifconfig` fails when neither `ip` nor `ifconfig` command exists on a UNIX-like system. In such a case, just ignore the exception.
hanazuki
force-pushed
the
error-handling
branch
from
808a49f to
cb2f6c7
Compare
|
Hi, I have same issue in containers where there is no |
| if os_class == :windows | ||
| begin | ||
| begin | ||
| if os_class == :windows |
There was a problem hiding this comment.
Use the return of the conditional for variable assignment and comparison.
| @@ -625,14 +627,16 @@ def self.mac_address | |||
|
|
|||
| os_class = UUID.os_class | |||
|
|
|||
| if os_class == :windows | |||
| @@mac_address = | |||
There was a problem hiding this comment.
Replace class var @@mac_address with a class instance var.
|
I need to dedicate some time to testing this before I merge, and unfortunately that time is something I just don't have at the moment. I will try to get to it as soon as I can, but it could be awhile before I can give this the attention it needs. |
|
I'll probably try to update to a Docker-based CI setup since that's really what this kind of project desperately needs in order to effectively automate testing of weird environments. |
|
@sporkmonger Any progress on this? |
Hi, @sporkmonger!
I'm now working with some chroot-ed Linux environment where neither
ipnorifconfigcommand is accessible. In such an environment I've found thatUUIDTools::UUID.ifconfigfails in trying to invoke an incomplete command such as" addr list"(path ofipis missing!).This patch makes the method ignore such a failure and return an empty string.