Marks strings mutable in preparation for enable-frozen-string-literal #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for all strings to be frozen as default, this gets test suite passing with RUBYOPT=--enable-frozen-string-literal
houndci-bot
reviewed
Aug 28, 2024
houndci-bot
reviewed
Aug 28, 2024
radville
force-pushed
the
radville/frozen-strings
branch
from
ee6f48d to
d552d13
Compare
bquorning
approved these changes
Oct 28, 2024
|
cc @sporkmonger in case this PR was overlooked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for all strings to be frozen as default, this gets test suite passing with RUBYOPT=--enable-frozen-string-literal
When adding
--enable-frozen-string-literalto our codebase, we started to see frozen string errors coming fromuuidtools.These changes remove those errors by unfreezing strings when they should be mutable. They get the test suite to pass with RUBYOPT="--enable-frozen-string-literal", which will be the default in the future.