Respect oneIndexedParameters property when serialising Page to JSON #3161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed when using Spring Data in my project, I can set property
spring.data.web.one-indexed-parameters
to true and have my page numbering start from 1 in my API. However when returning Page from controller, this value is not respected and it will always return page number decreased by 1.This PR fixes that by adding
oneIndexedParameters
attribute toSpringDataJacksonConfiguration.PageModule
class. I have also addedPageModuleCustomizer
to be used to define wether PageModule will assume 1-based page number indexes in the request parametersIn order to respect this property, a PageModuleCustomizer needs to be defined:
Also this bean can be defined in Spring Boot Autoconfigure project, so spring will automatically take care of this.