Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Handle merging directories containing same-named read-only files #56

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

PR: Handle merging directories containing same-named read-only files #56

wants to merge 1 commit into from

Conversation

Apteryks
Copy link

Fixes #54.

  • docrepr/utils.py (merge_directories): Also handle 'shutil.Error'
    exceptions.

@ccordoba12 ccordoba12 added this to the v0.2.1 milestone May 28, 2022
@ccordoba12 ccordoba12 changed the title utils: Handle merging directories containing same-named read-only files. PR: Handle merging directories containing same-named read-only files May 28, 2022
@CAM-Gerlach
Copy link
Member

Please update reference screenshots

CAM-Gerlach
CAM-Gerlach previously approved these changes Jun 11, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, thanks. LGTM.

Funny enough, I just had to deal with a similar problem in another package I maintain, and fell back to writing my own error-tolerant copytree routine, only to later discover there was already one here, heh.

@CAM-Gerlach
Copy link
Member

For whatever reason, the checks aren't retriggering here even though I re-ran them. @Apteryks , could you e.g. git commit --amend your first commit (e.g. tweak the commit message to remove the period in the summary line, which doesn't belong in titles) and then force push to do so? Or would you mind if I did so for you, just to get the CI s to trigger?

@Apteryks
utils: handle merging directories containing same-named read-only files
002eb3e 
Fixes spyder-ide#54.

* docrepr/utils.py (merge_directories): Also handle 'shutil.Error'
exceptions.
@Apteryks
Copy link
Author

Done! But feel free to adjust the way you like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAM-Gerlach CAM-Gerlach CAM-Gerlach left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@Apteryks Apteryks

Labels
type:Bug
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging this pull request may close these issues.

Permission denied error when sphinx template files are read-only
3 participants
@Apteryks @CAM-Gerlach @ccordoba12