Merge pull request #14 from dalthviz/config_update

PR: Remove some unused configs and do some final code clean up

kite_provider/client.py

@@ -13,7 +13,7 @@
 from qtpy.QtCore import QObject, QThread, Signal, QMutex
 import requests
 
-#Spyder imports
+# Spyder imports
 from spyder.config.base import _, running_under_pytest
 from spyder.py3compat import TEXT_TYPES
 

kite_provider/parsing/__init__.py

@@ -4,7 +4,6 @@
 # Licensed under the terms of the MIT License
 
 # Standard library imports
-import logging
 import re
 
 

kite_provider/provider.py

@@ -25,8 +25,6 @@
 from spyder.api.config.decorators import on_conf_change
 from spyder.config.base import _, running_under_pytest, get_module_data_path
 from spyder.plugins.completion.api import SpyderCompletionProvider
-from spyder.plugins.mainmenu.api import ApplicationMenus, ToolsMenuSections
-from spyder.utils.icon_manager import ima
 from spyder.utils.image_path_manager import IMAGE_PATH_MANAGER
 from spyder.utils.programs import run_program
 
@@ -39,16 +37,16 @@ class KiteProvider(SpyderCompletionProvider):
     DEFAULT_ORDER = 1
     SLOW = True
     CONF_DEFAULTS = [
-        ('spyder_runs', 1),
-        ('show_installation_dialog', True),
         ('show_onboarding', True),
         ('show_installation_error_message', True)
     ]
-    CONF_VERSION = "0.1.0"
+    CONF_VERSION = "1.0.0"
 
     def __init__(self, parent, config):
         super().__init__(parent, config)
-        IMAGE_PATH_MANAGER.add_image_path(get_module_data_path('kite_provider',relpath='images'))
+        IMAGE_PATH_MANAGER.add_image_path(
+            get_module_data_path('kite_provider', relpath='images')
+        )
         self.available_languages = []
         self.client = KiteClient(None)
         self.kite_process = None
@@ -74,7 +72,6 @@ def __init__(self, parent, config):
         # Config
         self.update_kite_configuration(self.config)
 
-
     # ------------------ SpyderCompletionProvider methods ---------------------
     def get_name(self):
         return 'Kite'
@@ -111,7 +108,15 @@ def start(self):
                     "directory that appears bellow, "
                     "and try a reinstallation:<br><br>"
                     "<code>{kite_dir}</code>").format(
-                        kite_dir=osp.dirname(path))
+                        kite_dir=osp.dirname(path)
+                    )
+
+                def wrap_message(parent):
+                    return QMessageBox.critical(
+                        parent, _('Kite error'), err_str
+                    )
+
+                self.sig_show_widget.emit(wrap_message)
 
         finally:
             # Always start client to support possibly undetected Kite builds

kite_provider/utils/status.py

@@ -100,5 +100,3 @@ def status(extra_status=''):
         return RUNNING + extra_status
     else:
         return NOT_RUNNING + extra_status
-
-

kite_provider/widgets/status.py

@@ -10,9 +10,6 @@
 # Standard library imports
 import logging
 
-# Third party imports
-from qtpy.QtCore import Slot
-
 # Spyder imports
 from spyder.api.widgets.status import StatusBarWidget
 from spyder.config.base import _
@@ -38,7 +35,6 @@ def __init__(self, parent, provider):
         is_installed, _ = check_if_kite_installed()
         self.setVisible(is_installed)
 
-
     def set_value(self, value):
         """Return Kite completions state."""
         kite_enabled = self.provider.get_conf(('enabled_providers', 'kite'),