Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Missing specification in pyproject.toml to make kite_provider discoverable #16

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Nov 14, 2023

  • Erroneous config in pyproject.toml causes the package to not be importable (installation works but then trying to import the package fails)
  • Fix test file and add steps to run tests on CI

Note: New release with the fix needs to be done after merging this

@dalthviz dalthviz added the bug Something isn't working label Nov 14, 2023
@dalthviz dalthviz added this to the v0.2.0 milestone Nov 14, 2023
@dalthviz dalthviz requested a review from jsbautista November 14, 2023 23:48
@dalthviz dalthviz self-assigned this Nov 14, 2023
@dalthviz dalthviz force-pushed the module_discoverable branch from 5970a99 to 122666d Compare November 17, 2023 21:00
@dalthviz dalthviz force-pushed the module_discoverable branch from 122666d to feddf14 Compare November 17, 2023 21:03
Copy link
Collaborator

@jsbautista jsbautista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dalthviz dalthviz merged commit 43c0868 into spyder-ide:main Nov 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants