PR: Improve compatibility for QtWidgets and QtGui modules between Qt5 and Qt6 bindings

[StSav012]

Place QAction, QActionGroup, QFileSystemModel, QShortcut, and QUndoCommand both in QtGui and QtWidgets.

The rationale. When developing under PySide6, one can import QAction from qtpy.QtGui. When the code moved to PyQt5, it fails.

This is a part of the insanely large PR I recently proposed. This way, it would be easier to review the changes.

Fixes #389

[dalthviz]

Thanks @StSav012 for the work here! It LGTM 👍

Also, I think it is okay to include this for 2.3.1, but just in case, what do you think @ccordoba12 and @CAM-Gerlach ?

[CAM-Gerlach]

LGTM, seems fine to me @dalthviz 👍

[ccordoba12]

Some stylistic suggestion, otherwise looks good to me.

[ccordoba12]

what do you think @ccordoba12?

Sure, I think that's fine because this is a small enough change.

[StSav012]

Thank you all. @ccordoba12 , I'll accept the changes as soon as I'll get to PC.

Unfortunately, the changes don't provide full compatibility, for the modules have changed and are evolving. The change has its roots in mistakes I've made. Hopefully, others won't.

[ccordoba12]

Unfortunately, the changes don't provide full compatibility, for the modules have changed and are evolving. The change has its roots in mistakes I've made. Hopefully, others won't.

I don't understand what you mean by this @StSav012. Are you talking about the changes you did in this PR? Or to my own suggestions?

[StSav012]

Oh, I'm sorry. I meant the PR. The reason I mentioned in the PR description is what I've stumbled upon.

As for your corrections, I'll gladly accept them all when I reach my PC. Tomorrow night, probably.

[CAM-Gerlach]

As for your corrections, I'll gladly accept them all when I reach my PC. Tomorrow night, probably.

(N.B., any of us can apply them for you if you want).

[StSav012]

That's not fair:

https://github.com/spyder-ide/qtpy/actions/runs/4456284626/jobs/7826634489#step:10:1757

https://github.com/spyder-ide/qtpy/actions/runs/4456284626/jobs/7826634794#step:10:1585-1587

[CAM-Gerlach]

Yeah those are unrelated and will be fixed when #414 is merged, hopefully very soon, and then you can rebase on that:

git fetch upstream
git switch moved-modules-in-qt6
git rebase upstream/master
git push --force-with-lease

[dalthviz]

PR #414 is now merged! 🎉

[CAM-Gerlach]

I've gone ahead and used GItHub's built-in "Update Branch" button to update this. @StSav012 , if you need to pull the changes locally, you'll need to do:

git fetch origin
git reset --hard origin/qtbindingsnotfounderror

[ccordoba12]

Looks good to me now, thanks @StSav012!

[StSav012]

Thank you all! I don't have much spare time these days. @CAM-Gerlach, I do appreciate that you've taken matters into your hands.

[dalthviz]

Thanks for all the work here @StSav012 !