Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Update CI and requirements for Spyder 6 and add some testing #14

Merged
merged 15 commits into from
Feb 28, 2023
Merged

PR: Update CI and requirements for Spyder 6 and add some testing #14

merged 15 commits into from
Feb 28, 2023

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz commented Feb 14, 2023 •
edited
Loading

Part of #12

@dalthviz dalthviz added the task label Feb 14, 2023
@dalthviz dalthviz added this to the v0.1.0 milestone Feb 14, 2023
@dalthviz dalthviz self-assigned this Feb 14, 2023
@dalthviz dalthviz changed the title [WIP] PR: Update CI and requirements for Spyder 6 [WIP] PR: Update CI and requirements for Spyder 6 and add some testing Feb 14, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 14, 2023 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 97.51553% with 4 lines in your changes missing coverage. Please review.

Project coverage is 76.09%. Comparing base (2c4d8c7) to head (007f48a).
Report is 28 commits behind head on main.

Files with missing lines Patch % Lines
spyder_env_manager/spyder/plugin.py 0.00% 1 Missing ⚠️
spyder_env_manager/spyder/widgets/main_widget.py 88.88% 1 Missing ⚠️
spyder_env_manager/tests/test_config.py 92.85% 1 Missing ⚠️
spyder_env_manager/tests/test_plugin.py 99.24% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main      #14       +/-   ##
===========================================
+ Coverage   36.22%   76.09%   +39.87%     
===========================================
  Files          15       16        +1     
  Lines         831      979      +148     
===========================================
+ Hits          301      745      +444     
+ Misses        530      234      -296

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dalthviz dalthviz force-pushed the spyder_6 branch 3 times, most recently from ce63e46 to 2c37f40 Compare February 20, 2023 18:30
@ccordoba12 ccordoba12 mentioned this pull request Feb 22, 2023
Merged
@dalthviz dalthviz changed the title [WIP] PR: Update CI and requirements for Spyder 6 and add some testing PR: Update CI and requirements for Spyder 6 and add some testing Feb 24, 2023
ccordoba12
ccordoba12 reviewed Feb 28, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small suggestions and questions for you @dalthviz, otherwise looks to me.

setup.py Outdated Show resolved Hide resolved
spyder_env_manager/spyder/widgets/main_widget.py Outdated Show resolved Hide resolved
spyder_env_manager/tests/test_plugin.py Outdated Show resolved Hide resolved
spyder_env_manager/tests/test_plugin.py Outdated Show resolved Hide resolved
spyder_env_manager/tests/test_plugin.py Outdated Show resolved Hide resolved
ccordoba12
ccordoba12 approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 41ed14a into spyder-ide:main Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 ccordoba12 approved these changes

Assignees

@dalthviz dalthviz

Labels
task
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dalthviz @codecov-commenter @ccordoba12