Optimize hero image with webp #225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conradolandia
force-pushed
the
optimize-hero-image
branch
from
5e45e26 to
d4a6bac
Compare
CAM-Gerlach
approved these changes
Mar 12, 2024
There was a problem hiding this comment.
After rebasing this on master, everything looks good now, besides an issue with the hero height firing on DOM ready but not asset load that this incidentally exposes, which you'll fix separately. Thanks @conradolandia !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the format of
spyder_website_bannerfrom png to webp. This change reduces the file size to 260K, solving issue #202.