Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1470 paths windows #1475

Open
wants to merge 22 commits into
base: main
Choose a base branch
from

Conversation

KeynesYouDigIt
Copy link

@KeynesYouDigIt KeynesYouDigIt commented Nov 16, 2024

Related Issue(s):

Description:
billy boy dab

Python 3.13 nuances the use of os.path.isabs - https://docs.python.org/3/library/os.path.html#os.path.isabs

So I changed the test to reflect that

TODO

  • some tests still failing!

PR Checklist:

  • Pre-commit hooks and tests pass (run scripts/test)
  • Documentation has been updated to reflect changes, if applicable
  • This PR maintains or improves overall codebase code coverage.
  • Changes are added to the CHANGELOG. See the docs for information about adding to the changelog.

@KeynesYouDigIt KeynesYouDigIt marked this pull request as draft November 16, 2024 22:50
@KeynesYouDigIt KeynesYouDigIt marked this pull request as ready for review November 16, 2024 23:06
@KeynesYouDigIt
Copy link
Author

KeynesYouDigIt commented Nov 23, 2024

OK! @gadomski , ready for a look now. This is a nuance that might relate to @jsignell 's work on #1472 - namely, os.path changed a bit in 3.13.

Happy to touch up style and/or squash commits, LMK!

@KeynesYouDigIt
Copy link
Author

@gadomski gadomski self-requested a review November 24, 2024 13:42
Copy link

codecov bot commented Nov 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.17%. Comparing base (3efd9dd) to head (c38a786).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1475   +/-   ##
=======================================
  Coverage   91.17%   91.17%           
=======================================
  Files          52       52           
  Lines        7251     7251           
  Branches      875      875           
=======================================
  Hits         6611     6611           
  Misses        460      460           
  Partials      180      180           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

tests/test_catalog.py Outdated Show resolved Hide resolved
Comment on lines +418 to +422
path_includes_drive: bool = (
sys.version_info.major == 3
and sys.version_info.minor >= 13
and os.name == "nt"
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you refactor this check out to a function, in case we want to re-use it elsewhere in tests? Thanks.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed I can! should be able to do that very soon.

@gadomski
Copy link
Member

Happy to touch up style and/or squash commits, LMK!

Thanks! This is great. No need to touch up commits, we squash-and-merge here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants