-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 1470 paths windows #1475
base: main
Are you sure you want to change the base?
Issue 1470 paths windows #1475
Conversation
CI passing example https://github.com/KeynesYouDigIt/pystac/actions/runs/11990954337 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1475 +/- ##
=======================================
Coverage 91.17% 91.17%
=======================================
Files 52 52
Lines 7251 7251
Branches 875 875
=======================================
Hits 6611 6611
Misses 460 460
Partials 180 180 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
path_includes_drive: bool = ( | ||
sys.version_info.major == 3 | ||
and sys.version_info.minor >= 13 | ||
and os.name == "nt" | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you refactor this check out to a function, in case we want to re-use it elsewhere in tests? Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed I can! should be able to do that very soon.
Thanks! This is great. No need to touch up commits, we squash-and-merge here. |
Related Issue(s):
Description:
Python 3.13 nuances the use of
os.path.isabs
- https://docs.python.org/3/library/os.path.html#os.path.isabsSo I changed the test to reflect that
TODO
PR Checklist:
scripts/test
)