Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

made tileLayer accept async buildTileUrlTemplate function #68

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

randyberos
Copy link
Contributor

This enables async function for the buildTileUrlTemplate option.

Will solve the issue related to this.

@DanielJDufour
Copy link
Member

Awesome. On the face of it, looks great! Could you add a test just to double check? Thank you!

@m-mohr
Copy link
Collaborator

m-mohr commented Sep 30, 2023

Just for awareness: This PR is against the codebase for the stac-layer rewrite which will likely will be released as 1.x, but it may never appear in STAC Browser, which is still on the old codebase (0.x). It depends a bit on funding whether STAC Browsers next version will be using stac-layer 0.x, stac-layer 1,x, or ol-stac 1.x.

@randyberos
Copy link
Contributor Author

Changed the tilers/titiler/build-tile-url-template.html test to use async buildTileUrlTemplate. Test on rendering the COG using buildTileUrlTemplate still works as intended.

@DanielJDufour DanielJDufour merged commit 1b39f02 into stac-utils:main Oct 14, 2023
@m-mohr
Copy link
Collaborator

m-mohr commented Oct 14, 2023

I updated the README to reflect the change, too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants