Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add REST client #12

Merged
merged 4 commits into from
May 30, 2024
Merged

Add REST client #12

merged 4 commits into from
May 30, 2024

Conversation

puerco
Copy link
Member

@puerco puerco commented May 29, 2024

This PR migrates a generalized version of the trusty client originally written for minder. We now expose the API response and its components in reusable objects. It also adds unit tests for the client functions.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco puerco requested a review from JAORMX May 29, 2024 00:40
Copy link
Member

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have anything else to add apart from what Ozz's comment 👍

This commit imports a generalized version of the trusty client
originally written for minder.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds the ecosystem type to the types libraries, it also introduces
a new Ecosystem field in the dependency type.

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
This commit adds the unit tests for the REST client library

Signed-off-by: Adolfo García Veytia (Puerco) <[email protected]>
@puerco
Copy link
Member Author

puerco commented May 29, 2024

OK, should be ready to go now.

@JAORMX JAORMX merged commit 10d5797 into stacklok:main May 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants