Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always build multiarch tests for the konflux workflows #1974

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

Molter73
Copy link
Collaborator

@Molter73 Molter73 commented Nov 28, 2024

Description

Since konflux always builds multiarch images and we always try to test them, we should force the test container to build in multiarch mode. If we don't, then we get test failures on the konflux integration tests for PRs due to the tester image not existing.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

CI should be enough.

Since konflux always builds multiarch images and we always try to test
them, we should force the test container to build in multiarch mode. If
we don't, then we get test failures on the konflux integration tests for
PRs due to the tester image not existing.
@Molter73 Molter73 marked this pull request as ready for review November 28, 2024 15:08
@Molter73 Molter73 requested a review from a team as a code owner November 28, 2024 15:08
@Molter73 Molter73 merged commit 506d483 into master Dec 2, 2024
137 of 161 checks passed
@Molter73 Molter73 deleted the mauro/build-multiarch-tests-konflux branch December 2, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants