Fix RuntimeConfigFileTestSuite cleanups #1989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On top of fixing the `AfterTest` method signature, a suite teardown has been added for removing the /tmp/collector-test directory, this is not strictly needed, but it's good practise to cleanup completely after all tests.
erthalion
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On top of fixing the
AfterTestmethod signature, a suite teardown has been added for removing the /tmp/collector-test directory, this is not strictly needed, but it's good practise to cleanup completely after all tests.Checklist
Automated testing
If any of these don't apply, please comment below.
Testing Performed
Run the
TestRuntimeConfigFilelocally and checked the directory and configuration files are properly cleaned up.