Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix button inconsistencies #342

Merged
merged 3 commits into from
Nov 5, 2024
Merged

Fix button inconsistencies #342

merged 3 commits into from
Nov 5, 2024

Conversation

ianthetechie
Copy link
Contributor

Pretty straightforward. Does all the things that probably should have been done the first time ;)

  • Builds on NavigationUIButton, which we designed specifically for this consistency
  • Adds shadow modifier that we used to have everywhere else.
  • (Possibly contentious) Moves shadow modifiers inside the views. We have these strewn all over the place and it just makes things confusing and incosistent IMO; these views are already quite opinionated and often have half a dozen modifiers internally anyways. I vaguely remember removing these at one point due to spurious snapshot differences across OS versions, but we have to lock these anyways for CI, so I'd like to revisit if that's possible. This is all in a separate commit so can roll back easily enough if you'd prefer not to go this far.

@ianthetechie ianthetechie mentioned this pull request Nov 4, 2024
Copy link
Collaborator

@Archdoog Archdoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good per the snapshot tests 👍

@ianthetechie ianthetechie merged commit 4c048c4 into main Nov 5, 2024
14 checks passed
@ianthetechie ianthetechie deleted the mute-button-ui-consistency branch November 5, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants