Replace unsafeAddr by baseAddr

[lchenut]

It should fix some of the https://github.com/status-im/nim-protobuf-serialization CI problems.
The rest of the problems should be solved with #31

[arnetheduck]

hm, I'm not convinced baseAddr is well-defined for empty arrays - taking the address of an empty array is not meaningful really - I guess using baseAddr points to these places more clearly, but we should probably revisit this at some point cc @zah (the risk being that with baseAddr, we turn a Defect into runtime-undetected UB).

The alternative solution here might be to avoid copyMem using something like assign2.

[arnetheduck]

charsToBytes should call https://github.com/nim-lang/Nim/blob/version-1-2/lib/system.nim#L2981 instead

[arnetheduck]

should also add a test for writing/finalizing with empty array

[arnetheduck]

baseAddr has been fixed to return ptr T (so the ptr byte cast is no longer necessary) and to return nil when the source is empty, so this code will now be as safe as it gets

[arnetheduck]

devel failure unrelated cc @zah

[bung87]

where is baseAddr defined ？ I get .nimble\pkgs2\faststreams-0.3.0-62f7ac8fb200a8ecb9e6c63f5553a7dad66ae613\faststreams\outputs.nim(535, 34) Error: undeclared identifier: 'baseAddr'

nim-1.6.10

[arnetheduck]

it's part of nim-stew in ptrops - likely, you're using some old version

[bung87]

really? it seems all the status-im packages my project relys has no tag, so no version restrictions, I also checked nimble packages dir, all of them match the latest version declared in nimble file. it seems template symbol resolution problem to me.

[bung87]

hmm, you're right, when not versioned nimble not trying getting the latest.