[BUG] fixes an incorrect reference to the old create contract class for v2 #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piyalbasu
approved these changes
Nov 13, 2024
…ntract types, add branch for craete contract v2 in invocation crawler for sac cases
| }; | ||
| } as FnArgsCreateSac; | ||
|
|
||
| if (fn.switch().value === 2) { |
There was a problem hiding this comment.
It wasn't super clear to me through the xdr if this was possible for the SAC case but I think there's no reason to not include this line. If SACs will keep using v1 then this conditional won't ever be hit.
| contractId: rootJson.args.source, | ||
| networkDetails, | ||
| }); | ||
| const isToken = !rootJson.args.source |
There was a problem hiding this comment.
for both the invocation and sub invocation this should account for not having a source in the root args.
aristidesstaffieri
deleted the
bug/auth-entry-create-contract-args-parse-3
branch
Merged
aristidesstaffieri
added a commit
that referenced
this pull request
Nov 14, 2024
* [BUG] fixes an incorrect reference to the old create contract class for v2 (#1661) * fixes an incorrect reference to the old create contract class for v2 * adds test for create contract v1 in sub invoke * account for invocations that follow the deployer pattern in create contract types, add branch for craete contract v2 in invocation crawler for sac cases * updates tests for sac create constructor args and adds optional component to render them * removes comment in tests * adds unit test and jest view tests for creater contract deployer pattern (#1668)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reroll of #1655