Keep di52 compatibility #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the use of `bind()` in a way that is not compatible with di52 containers. It also adds a safety net on `send_events()` in the case that `$events` is null
borkweb
requested changes
Nov 9, 2023
alter the logic in send_events() Co-authored-by: Matthew Batchelder <[email protected]>
borkweb
requested changes
Nov 9, 2023
borkweb
previously approved these changes
Nov 9, 2023
borkweb
approved these changes
Nov 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the use of
bind()in a way that is not compatible with di52 containers.This is causing fatals in TEC product as they use the di52 container and bind always tries to build a class ( it would use getVar/setVar instead)
It also adds a safety net on
send_events()in the case where$eventsis null.BTRIA-2105