[FRAME-178]: QA Simplification #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Organizing Documentation
ChrisMKindred
approved these changes
Oct 12, 2023
| @@ -58,6 +58,7 @@ jobs: | |||
| run: | | |||
| cd ${GITHUB_WORKSPACE}/.. | |||
| ${SLIC_BIN} here | |||
| ${SLIC_BIN} php-version set 8.2 --skip-rebuild | |||
There was a problem hiding this comment.
This is the PHP version that is running in slic right? I realize that everything should work on all PHP versions but wouldn't we want to run the tests against the minimum supported version instead of the most recent?
There was a problem hiding this comment.
When I updated wp-browser to fix the WP-CLI issue we've talked about before, the new version requires PHP >= 8.
Even before this though, Slic was using 7.4 to test, and we handled the compatibility checking with PHPCS. I don't think this exposes us to introducing incompatibilities, but it does help us handle newer versions of PHP.
…tests Improve Test Coverage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.