Add support for wrapping message in Option #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neil Shen <[email protected]>
Results in Intel(R) Xeon(R) CPU E5-2630 v4 @ 2.20GHz ``` test clone_and_drop_message_field ... bench: 148 ns/iter (+/- 24) test clone_and_drop_message_field_with_option ... bench: 36 ns/iter (+/- 5) ``` Signed-off-by: Neil Shen <[email protected]>
Signed-off-by: Neil Shen <[email protected]>
MzChynaBlackInc
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MessageFieldhas a noticeable overhead where there are lots of small nested messages being created and dropped frequently, because it wraps messages inBox.This PR add an option
option_for_messageto rustproto that allows to wrap a message in anOptionin generated code.Also adding a simple benchmark shows the improvement.
I would appreciate feedback!