Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix hyperlink issue on Edge/IE #126

Merged
merged 5 commits into from
Aug 19, 2017

Conversation

hungqcao
Copy link
Contributor

Instead of calling markSelection in focus and clearing browser selection (which will cause issue of losing focus on Edge), we will markSelection at the time users click to the hyperlink button. Also always clearing the highlighted selection when bootstrap dropdown closes or losing focus on hyperlink input.

@spreadred
Copy link

spreadred commented Aug 18, 2017

I tested in Edge and Internet Explorer. It appears to fix the problem with not being able to use the hyperlink button.

I did notice, however, that it only works properly if you type text first, select that text, and then click the hyperlink button. If you simply click the hyperlink button and type your link, it does not add it to the editor window like it does in Chrome.

Can someone else test and confirm my findings?

@spreadred
Copy link

I have pushed @hungqcao changes to my fork with some minor edits of my own. I will create a new issue regarding discrepancies in how Chrome allows creation of a hyperlink straight from the button, without requiring a text selection while other browsers do not..

@hungqcao
Copy link
Contributor Author

@kaptainkommie I will take a look at the issue about not having previous selection on Edge. I did notice it during testing though.

@spreadred
Copy link

@hungqcao I created issue #127 for this, I have provided a bit more information there.

@steveathon steveathon merged commit b74d564 into steveathon:2.0-dev Aug 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants