Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dac copied from stm32f0xx-hal #175

Merged
merged 1 commit into from
Jul 13, 2020
Merged

dac copied from stm32f0xx-hal #175

merged 1 commit into from
Jul 13, 2020

Conversation

jacobrosenthal
Copy link
Contributor

Copied from stm32f0xx-hal

We should maybe wait until this shakes out?
https://github.com/stm32-rs/stm32f0xx-hal/pull/70/files

@therealprof
Copy link
Member

We should maybe wait until this shakes out?
https://github.com/stm32-rs/stm32f0xx-hal/pull/70/files

How do you mean?

therealprof
therealprof requested changes Jul 5, 2020
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test it right now but looks mostly okay.

Could use some commit squashing to get rid of the intermediate whack commits and of course it's missing the CHANGELOG entry.

@jacobrosenthal
Copy link
Contributor Author

Squashed and Changelog.
ah. Wrong link earlier.
stm32-rs/stm32f0xx-hal#94

therealprof
therealprof approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@therealprof therealprof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for now. Lot's of room for improvements for later.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 13, 2020

Build succeeded:

@bors bors bot merged commit e03118d into stm32-rs:master Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@therealprof therealprof therealprof approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacobrosenthal @therealprof