Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(functions): add support unicode to regexp pattern #2558

Closed
wants to merge 1 commit into from
Closed

feat(functions): add support unicode to regexp pattern #2558

wants to merge 1 commit into from

Conversation

Ti-webdev
Copy link

Checklist

  • Tests added / updated
  • [-] Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Additional context

Fix unicode issue:
https://stackoverflow.com/questions/68840457/can-i-use-the-unicode-flag-within-a-json-schema-pattern-regular-expression

@Ti-webdev Ti-webdev requested a review from a team as a code owner December 4, 2023 05:06
@Ti-webdev
Copy link
Author

up

P0lip
P0lip suggested changes Jan 16, 2024
View reviewed changes
Copy link
Contributor

@P0lip P0lip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can already specify a flag as follows

spectral/packages/functions/src/__tests__/pattern.test.ts

Line 21 in 510fc5a

expect(await runPattern('aBc', { match: '/[abc]+/im' })).toEqual([]);

I'd rather not modify the default as that would be a soft breaking change.

@P0lip P0lip force-pushed the develop branch 3 times, most recently from dc90b7a to c22f408 Compare April 4, 2024 13:29
@mnaumanali94
Copy link
Contributor

Closed as not doing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@P0lip P0lip P0lip requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Ti-webdev @mnaumanali94 @P0lip